Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsticky "Appears in" element from bottom of page #278

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

jonathanhefner
Copy link
Member

Stickying the "Appears in" <details> at the bottom of the page causes the element to jump up when it is expanded, which is unexpected and unusual. Since the element already hides information by default, there is no need to force it to stay all the way at the bottom of the page. This commit removes the sticky positioning and fixes some inconsistencies in the grid definition.

Before After
before1 after1
before2 after2

Stickying the "Appears in" `<details>` at the bottom of the page causes
the element to jump up when it is expanded, which is unexpected and
unusual.  Since the element already hides information by default, there
is no need to force it to stay all the way at the bottom of the page.
This commit removes the sticky positioning and fixes some
inconsistencies in the grid definition.
@jonathanhefner jonathanhefner merged commit 9eee87e into rails:main Aug 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant